[GitHub] activemq-artemis pull request #1786: ARTEMIS-1616 OpenWire improvements

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1786#discussion_r162636748
  
    --- Diff: 
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java
 ---
    @@ -361,13 +371,68 @@ public int hashCode() {
           }
        }
     
    +   private static SimpleString[] splitWithCachedString(final SimpleString 
simpleString, final int delim) {
    --- End diff --
    
    Ah :) nice, very subtle. 


---