Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1849#discussion_r166001057
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
---
@@ -713,12 +730,16 @@ public void reconnect(AMQConnectionContext
existingContext, ConnectionInfo info)
context.incRefCount();
}
+ private static void traceSendCommand(Command command) {
+ ActiveMQServerLogger.LOGGER.trace("sending " + command);
+ }
+
/**
* This will answer with commands to the client
*/
public boolean sendCommand(final Command command) {
- if (ActiveMQServerLogger.LOGGER.isTraceEnabled()) {
- ActiveMQServerLogger.LOGGER.trace("sending " + command);
+ if (ACTIVE_MQ_SERVER_LOGGER_TRACE_ENABLED) {
--- End diff --
You're quite right, probably I will revert it but it is actually an issue
and probably could be turned into a lock-free way: actually it really create a
point of contentions for any send of messages, affecting responses and
consumers all together...not good!
---
