Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2007#discussion_r180457921
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java
---
@@ -39,7 +39,15 @@
PROPOSAL(18),
PROPOSAL_RESPONSE(19),
UNPROPOSAL(20),
- CONSUMER_SLOW(21);
+ CONSUMER_SLOW(21),
+ ADDRESS_ADDED(22),
+ ADDRESS_REMOVED(23),
+ CONNECTION_CREATED(24),
+ CONNECTION_DESTROYED(25),
+ SESSION_CREATED(26),
+ SESSION_CLOSED(27),
+ MESSAGE_DELIVERED(28),
--- End diff --
@cshannon when you go to ServerConsumerImpl, there's already a previous
call you added to afterDeliver, that's apparently gets called every time.
Shouldn't that be changed to call this new component you wrote?
I guess that's where I'm getting confused. I read the code as part of your
change now and I see that's an older change you added back in Jan this year.
Can you take a look for the relationship between that change and this one
now?
---
