Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2010#discussion_r184600627
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -2712,6 +2714,11 @@ private Message makeCopy(final MessageReference ref,
final boolean expiry) throw
private Message makeCopy(final MessageReference ref,
final boolean expiry,
final boolean copyOriginalHeaders) throws
Exception {
+ if (ref == null) {
+ ActiveMQServerLogger.LOGGER.nullRefMessage();
+ NULL_REF.createException("Reference to message is null");
--- End diff --
Yeah, i forgot to throw that. I am throwing ActiveMQNullRefException, which
under the hood does super(ActiveMQExceptionType.NULL_REF). Is that ok?
---
