Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2075#discussion_r186412623
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCursorProviderImpl.java
---
@@ -239,8 +239,28 @@ public void stop() {
for (PageSubscription cursor : activeCursors.values()) {
cursor.stop();
}
-
- executor.shutdownNow();
+ int pendingCleanupTasks = scheduledCleanup.get();
--- End diff --
`PagingStoreImpl` seems the one that is owning the executor
I will move the `executor.shutdownNow` from the `PageCursorProvider` to
`PagingStoreImpl` while leaving at least the flush of the cleanup tasks on it
:+1:
Good points!
---
