Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2156#discussion_r197624300
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
 ---
    @@ -511,6 +512,10 @@ public QueueBinding updateQueue(SimpleString name,
                 changed = true;
                 queue.setExclusive(exclusive);
              }
    +         if ((user != null && !user.equals(queue.getUser()) || (user == 
null && queue.getUser() != null))) {
    +            changed = true;
    +            queue.setUser(SimpleString.toSimpleString(user));
    --- End diff --
    
    Slight issue here in the logic that the older methods if invoked to update 
a queue will clear the user associated with the queue , as they will pass in 
null causing user to be set to null no matter. 


---

Reply via email to