Github user jdanekrh commented on the pull request:
https://github.com/apache/activemq-artemis/commit/177e6820b541e0a71b952eebf503a4d2235910c5#commitcomment-29554432
In
hornetq-server/src/main/java/org/hornetq/core/server/impl/RefsOperation.java:
In
hornetq-server/src/main/java/org/hornetq/core/server/impl/RefsOperation.java on
line 194:
This really looks wrong. The auto-suggested fix seems wrong too. The code
is in the latest master still.
>artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/RefsOperation.java:184:
error: [ModifyingCollectionWithItself] Using a collection function with itself
as the argument.
> listRet.addAll(listRet);
> ^
> (see http://errorprone.info/bugpattern/ModifyingCollectionWithItself)
> Did you mean 'this.refsToAck.addAll(listRet);'?
---
