Github user tabish121 commented on a diff in the pull request:

    https://github.com/apache/activemq-nms-amqp/pull/2#discussion_r204159065
  
    --- Diff: NMS.AMQP/NMS-AMQP.csproj ---
    @@ -0,0 +1,124 @@
    +<?xml version="1.0" encoding="utf-8"?>
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one
    +or more contributor license agreements.  See the NOTICE file
    +distributed with this work for additional information
    +regarding copyright ownership.  The ASF licenses this file
    +to you under the Apache License, Version 2.0 (the
    +"License"); you may not use this file except in compliance
    +with the License.  You may obtain a copy of the License at
    +  http://www.apache.org/licenses/LICENSE-2.0
    +  Unless required by applicable law or agreed to in writing,
    +  software distributed under the License is distributed on an
    +  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +  KIND, either express or implied.  See the License for the
    +  specific language governing permissions and limitations
    +  under the License.
    +  -->
    +<Project Sdk="Microsoft.NET.Sdk">
    +  <!--<Import 
Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props"
 
Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')"
 />-->
    +  <PropertyGroup>
    +    <Configuration Condition=" '$(Configuration)' == '' 
">Debug</Configuration>
    +    <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
    +    <ProjectGuid>{0D8CF699-9702-4EC6-8719-C2968D32F09A}</ProjectGuid>
    +    <OutputType>Library</OutputType>
    +    <AppDesignerFolder>Properties</AppDesignerFolder>
    +    <RootNamespace>NMS.AMQP</RootNamespace>
    --- End diff --
    
    The project should carry the Apache name e.g.  Apache.NMS.AMQP


---

Reply via email to