Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2187#discussion_r208837845
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java
---
@@ -189,16 +185,24 @@ public void kill() {
this.killed = true;
}
+ private void setHandlers() {
+
sessionChannel.setCommandConfirmationHandler(commandConfirmationHandler);
--- End diff --
@jbertram
So i think to solve the issue of the responseCache still having reference
and the memory leak, we can just add in the code that acks the commands upto
the latest, we can just also call the cache, it will mean a double invocation
but as you noted for the interim with your flag it actually wont have effect.
Thought? Ill send a pr in a bit to your branch
---
