Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2427#discussion_r232491068
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java
---
@@ -887,55 +876,48 @@ public CoreMessage putBytesProperty(final String key,
final byte[] value) {
@Override
public CoreMessage putCharProperty(SimpleString key, char value) {
messageChanged();
- checkProperties();
- properties.putCharProperty(key, value);
+ checkProperties().putCharProperty(key, value);
return this;
}
@Override
public CoreMessage putCharProperty(String key, char value) {
messageChanged();
- checkProperties();
- properties.putCharProperty(SimpleString.toSimpleString(key,
getPropertyKeysPool()), value);
+ checkProperties().putCharProperty(SimpleString.toSimpleString(key,
getPropertyKeysPool()), value);
--- End diff --
Delegate to simplestring method variant. Ditto for all cases on this
---
