[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

[franz1981]

Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2488#discussion_r244986350
  
    --- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionCreateConsumerMessage.java
 ---
    @@ -25,20 +26,24 @@
     
        private SimpleString filterString;
     
    +   private int priority;
    --- End diff --
    
    I will change it as `byte` if we are not planning to support priorities > 
127 ie `Byte::MAX_VALUE`
    For small messages it *could* save some space (TBH to be verified with JOL 
tool)


---