Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2494#discussion_r246558406
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/LivePageCacheImpl.java
---
@@ -28,15 +28,49 @@
/**
* This is the same as PageCache, however this is for the page that's
being currently written.
*/
--- End diff --
Isn't this mixing the collection implementation itself into the
LivePageCache?
isn't there a way to implement this logic into its own structure? Like
PageCache using a generic ChunkArray (a name I just came up here)?
I'm a bit concerned on maintaining the business side of this issue (that is
the PageCache) with the speedy implementation of a collection.
---
