michaelandrepearce commented on a change in pull request #2522: ARTEMIS-2239
Zero-copy NIO/MAPPED TimedBuffer
URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251200460
##########
File path:
artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/nio/NIOSequentialFile.java
##########
@@ -51,6 +55,34 @@ public NIOSequentialFile(final SequentialFileFactory
factory,
this.maxIO = maxIO;
}
+ @Override
+ protected TimedBufferObserver createTimedBufferObserver() {
+ return new LocalBufferObserver() {
Review comment:
At least make it a nested class. Anonymous classes whilst not impossible to
debug, just having it named makes stacks trace, heap dumps etc that little bit
easier to quickly read and understand.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
