clebertsuconic commented on a change in pull request #2527: NO-JIRA add logging 
to LegacyLDAPSecuritySettingPlugin
URL: https://github.com/apache/activemq-artemis/pull/2527#discussion_r251929829
 
 

 ##########
 File path: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/LegacyLDAPSecuritySettingPlugin.java
 ##########
 @@ -303,6 +303,13 @@ private LegacyLDAPSecuritySettingPlugin 
populateSecurityRoles() {
 
       securityRoles = new HashMap<>();
       try {
+         if (logger.isDebugEnabled()) {
+            logger.debug("Performing LDAP search: " + destinationBase);
 
 Review comment:
   I don't mean to be annoying, but when I deal with big loggers.. it's a lot 
easier if this was a single logger.debug call
   
   
   easier to identify on the logger output... and on user's environments even 
more.  A lot of our users are using logger aggregators now.. so it would be a 
lot easier with a single call here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to