-1 (non-binding) - There is content in the archive permissioned in a way that you cant access / delete it once you extract it, a little like the initial 1.8.0 API RC archive had. - There are some files that should have headers which dont. Unfiltered RAT output summary below.
Seperately from that, I'd suggest having a parent dir for the contents, unless theres a reason it isnt possible? Most releases have them and I'd say its far nicer overall but particularly when extracing things, and also helps when e.g .dll's dont have version numbers in their filename. I tend to make the source one differ with a -src suffix to aid side by side extraction also. I guess 1.8.0 was selected given prior versioning behaviour for some of the other NMS impls? Feels a little strange for the first release, plus is that meaning only 1.8.x releases until the API changes? Now would seem to be the best time to do something different if it was thought desirable. Robbie ***************************************************** Summary ------- Generated at: 2019-10-03T16:13:46+01:00 Notes: 2 Binaries: 3 Archives: 0 Standards: 225 Apache Licensed: 201 Generated Documents: 0 JavaDocs are generated, thus a license header is optional. Generated files do not require license headers. 24 Unknown Licenses ***************************************************** Files with unapproved licenses: ./README.md ./apache-nms-amqp.sln ./src/NMS.AMQP/NmsDurableTopicSubscriber.cs ./src/NMS.AMQP/Meta/TransactionInfo.cs ./src/PingPong/Ping.cs ./src/PingPong/PingPong.csproj ./src/PingPong/Pong.cs ./src/PingPong/Program.cs ./src/PingPong/Stats.cs ./test/Apache-NMS-AMQP-Test/NLog.config ./test/Apache-NMS-AMQP-Test/TestSuite.config ./test/Apache-NMS-AMQP-Test/Integration/MessageExpirationIntegrationTest.cs ./test/Apache-NMS-AMQP-Test/TestAmqp/NLogAdapter.cs ./test/Apache-NMS-AMQP-Test/TestAmqp/BasicTypes/ConnectionError.cs ./test/Apache-NMS-AMQP-Test/TestAmqp/BasicTypes/FrameCodes.cs ./test/Apache-NMS-AMQP-Test/TestAmqp/BasicTypes/TerminusExpiryPolicy.cs ./test/Apache-NMS-AMQP-Test/config/Adapter.runsettings ./test/Apache-NMS-AMQP-Test/config/cert/ReadMe.md ./test/Apache-NMS-AMQP-Test/config/cert/broker.crt ./test/Apache-NMS-AMQP-Test/config/cert/broker.key ./test/Apache-NMS-AMQP-Test/config/cert/ca.crt ./test/Apache-NMS-AMQP-Test/config/cert/ca.key ./test/Apache-NMS-AMQP-Test/config/cert/client.crt ./test/Apache-NMS-AMQP-Test/config/cert/client.key ***************************************************** On Thu, 3 Oct 2019 at 11:49, Michael Pearce <[email protected]> wrote: > > Hi All, > > I have put together a spin for a Apache NMS AMQP release, please > check it and vote accordingly. > > This release effectively will be the first release of a NMS AMQP client.. > > Also includes some modernisation of the project that was needed to > make the release, updating for latest visual studio, and lastly, > creating a nuget package, that once approved, we can publish to nuget. > > The files can be grabbed > from:https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-amqp/1.8.0-rc1/ > > The JIRAs assigned for this release can be found: > > https://issues.apache.org/jira/browse/AMQNET-618?jql=project%20%3D%20AMQNET%20AND%20fixVersion%20%3D%201.8.0%20AND%20component%20%3D%20AMQP > > > > Regards, > Michael
