It might be worth raising a fresh PR for finishing off review after you've done the next set of polish, the existing one has seen such a bunch of change and as a result has got so big as to be a bit unmanageable :)
On Fri, 23 Oct 2020 at 15:49, Clebert Suconic <[email protected]> wrote: > > I am obviously pushing back the release.. I will do as soon as I we > merge https://github.com/apache/activemq-artemis/pull/3294 (which will > include some tests before I merge it) > > On Mon, Oct 19, 2020 at 10:47 AM Clebert Suconic > <[email protected]> wrote: > > > > I'm planning to finish my work on Server Connections > > (https://github.com/apache/activemq-artemis/pull/3294) on the next day > > or 2, and I would like to start cutting a release on Friday, with the > > Vote thread sent on monday. > > > > That means I will have everything ready to go for a vote on Friday, > > and the release vote to be sent on monday. > > > > for the github Pull Requests under review I will also make sure we > > merge current relevant PRs... so, if you could make sure you send your > > pending changes.. and could even nudge me with a comment on your > > github pull requet tagging my name that you would like to include such > > PR. (feel free to communicate here as well if you prefer). > > > > -- > > Clebert Suconic > > > > -- > Clebert Suconic
