Hi Tim, I used the official recommended tooling to generate SHA the first time, but Robbie compiled that the format was wrong. I don't know what else I can do.
Regarding the missing headers, do you have any tooling (or script) that could help me with scanning the files beforehand, so I don't have to manually go through every single file? Maybe this kind of check should be included in the CI pipeline? Thanks, KP On Thu, Jul 8, 2021 at 5:30 PM Timothy Bish <[email protected]> wrote: > On 6/27/21 4:49 PM, Havret wrote: > > Hi, > > > > This is the second run for activemq-nms-amqp 1.8.2. > > > > I've added the missing headers, updated the license files, and generated > > SHA512 using powershell not gpg, so it should be more in line with what > you > > guys are used to. > > > > The files can be grabbed from: > > > https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-amqp/1.8.2-rc2/ > > > > Please check it and vote accordingly. > > > > Regards, > > KP > > > +0 > > There still appear to be some missing license headers in test code such as: > > ./test/Apache-NMS-AMQP-Interop-Test/NmsSessionTest.cs > > And I cannot get the sha files to validate using standard tooling > without hand editing the files as they don't see to follow normal file > formatting that's expected by the tooling as documented on the Apache > release validation guidelines. > > -- > Tim Bish > >
