Hello Micheal, Clebert, i have avoided thinking too much and i have come up with https://github.com/apache/activemq-artemis/commit/cae5f87b91b756e54b4f34b7511f242b4ad5723f
Honestly speaking, autoconfiguration makes things far simpler and prettier. I guess this is what Clebert meant when he advised me to keep things simple, Any comments you leave for me will be much appreciated. Thank you so much On Wed, Dec 29, 2021 at 12:44 PM Nabwegamo Brenda <brenser...@gmail.com> wrote: > Thanks Michael for your previous comments. > > Well I am a beginner with OpenTelemetry. I am going to do a little > research on how autoconfiguration works. I will send a PR of how I will > have understood the previous comments. > > On Wed, Dec 29, 2021 at 1:50 AM michael.andre.pearce > <michael.andre.pea...@me.com.invalid> wrote: > >> Left commentsTwo main feedback themes1) plugin should not be >> touching/changing any core code the whole point is that a user simply >> implements plugin independently to broker.2) Dependency, as previously >> mentioned it should not be having dependency to specific vendor exporter >> this is whole point of open telemetry that you plug/ code to open telemetry >> apis and then simply swap different exporters depending on tracing vendor >> selection of end user infra.Sent from my Galaxy >> -------- Original message --------From: Nabwegamo Brenda < >> brenser...@gmail.com> Date: 28/12/2021 14:06 (GMT+00:00) To: >> dev@activemq.apache.org Subject: Re: [DISCUSS] Open Telemetry with >> ActiveMQ Hello once again!I have created the first sample on my branch ( >> https://github.com/apache/activemq-artemis/commit/6042beac67a5ab48f6b8b930c528790695eb7e82) >> but i still have questions about its logic. I think I have tried >> toimplement most of the suggestions and I kindly request for your review. >> IfIt looks somewhat good to you, i can go ahead and create a PR for >> it.*Flaws in the PR*The way I implemented this, its like OpenTelemetry >> initialisation is calledmore than once, causing GlobalOpenTelemetry.set has >> already been called.<https://pastebin.com/aaK0nB2t>I kindly request you >> to take a look. Any form of suggestions or commentsare much welcomed.Thank >> you > >
