Unfortunately I am -1. I just checked the release and several Jiras don't have any unit tests for verification.
https://issues.apache.org/jira/browse/AMQ-8053 https://issues.apache.org/jira/browse/AMQ-8372 https://issues.apache.org/jira/browse/AMQ-8397 https://issues.apache.org/jira/browse/AMQ-8443 There might be more, I quit checking after the first several. All of these fixes and improvements need tests. It's important to add some tests to verify the actual bug or issue and to make sure it doesn't get broken in the future. I am not comfortable releasing this without having tests for these issues. The same of course goes into anything with 5.17.0. Obviously we don't need tests for trivial stuff (dependency upgrades, null pointer checks, etc) but other stuff should be tested. The biggest issue I have is AMQ-8443 which claims this is a fix for the "failover transport reconnect not working" but no demonstration of the issue or how the fix works in a unit test. On Wed, Feb 2, 2022 at 3:29 AM Francois Papon <francois.pa...@openobject.fr> wrote: > +1 (non-binding) > > Thanks! > > regards, > > François > > On 01/02/2022 21:41, Jean-Baptiste Onofre wrote: > > Hi everyone, > > > > I submit Apache ActiveMQ 5.16.4 release to your vote. > > > > This release includes important fixes and updates on the 5.16.x series, > especially: > > - fix couple of warnings/issues on JDK16+ > > - fix stack trace display on transports > > - better secure on WebConsole > > - several dependencies updates > > - and much more! > > > > Please take a look on the Release Notes for details: > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12350483 > > > > Maven staging repository is: > > > https://repository.apache.org/content/repositories/orgapacheactivemq-1244/ > > > > Dist staging repository is: > > https://dist.apache.org/repos/dist/dev/activemq/activemq/5.16.4/ > > > > Git tag: > > activemq-5.16.4 > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] -1 Don't approve the release (please provide specific comments) > > > > This vote will be open for at least 72 hours. > > > > Thanks ! > > Regards > > JB >
