No one is saying Matt's contributions are not welcome. Mistakes happen, we all screw up. I screw up all the time and have to fix stuff :)
I was just trying to point out that this is exactly why I considered it a blocker to not have tests before releasing. Anyways, I agree we should just move forward and improve things, my point was made. On Fri, Feb 4, 2022 at 12:30 PM Jean-Baptiste Onofré <j...@nanthrax.net> wrote: > We should run fulltest profile here. > > On 04/02/2022 18:28, Matt Pavlovich wrote: > > Weird this wasn’t caught during the PR CI test run (ref: > https://github.com/apache/activemq/pull/748/checks < > https://github.com/apache/activemq/pull/748/checks>) > > > > I’ll check into this one. > > > > -Matt > > > >> On Feb 4, 2022, at 11:07 AM, Christopher Shannon < > christopher.l.shan...@gmail.com> wrote: > >> > >> There is a regression on https://issues.apache.org/jira/browse/AMQ-8412 > >> > >> This commit prevents connections from terminating as they should and was > >> caught on Jenkins: > >> > https://builds.apache.org/job/ActiveMQ/job/ActiveMQ/job/activemq-5.16.x/169/testReport/junit/org.apache.activemq.transport.nio/NIOMaxFrameSizeCleanupTest/testMaxFrameSizeCleanupAutoNio/ > >> > >> This is the exact reason why I gave a -1 vote and considered no tests a > >> blocker because this Jira had no tests to verify the behavior change and > >> furthermore existing tests that actually found the issue were not > noticed. > >> > >> On Fri, Feb 4, 2022 at 9:52 AM Jean-Baptiste Onofré <j...@nanthrax.net> > wrote: > >> > >>> Hi all, > >>> > >>> as discussed on this thread, I cancel this vote in order to: > >>> > >>> - replace log4j 1.x by reload4j > >>> - add tests on new features/improvements added for 5.16.4 > >>> > >>> I will submit a new vote asap. > >>> > >>> Regards > >>> JB > >>> > >>> On 01/02/2022 21:41, Jean-Baptiste Onofre wrote: > >>>> Hi everyone, > >>>> > >>>> I submit Apache ActiveMQ 5.16.4 release to your vote. > >>>> > >>>> This release includes important fixes and updates on the 5.16.x > series, > >>> especially: > >>>> - fix couple of warnings/issues on JDK16+ > >>>> - fix stack trace display on transports > >>>> - better secure on WebConsole > >>>> - several dependencies updates > >>>> - and much more! > >>>> > >>>> Please take a look on the Release Notes for details: > >>>> > >>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12350483 > >>>> > >>>> Maven staging repository is: > >>>> > >>> > https://repository.apache.org/content/repositories/orgapacheactivemq-1244/ > >>>> > >>>> Dist staging repository is: > >>>> https://dist.apache.org/repos/dist/dev/activemq/activemq/5.16.4/ > >>>> > >>>> Git tag: > >>>> activemq-5.16.4 > >>>> > >>>> Please vote to approve this release: > >>>> > >>>> [ ] +1 Approve the release > >>>> [ ] -1 Don't approve the release (please provide specific comments) > >>>> > >>>> This vote will be open for at least 72 hours. > >>>> > >>>> Thanks ! > >>>> Regards > >>>> JB > >>> > > > > >
