+1, Everything looks good. I went through all the test failures and there are no issues that require cancelling the vote (just some problems with a couple tests themselves, flaky tests, and one spec jar problem that is an optional jar that only affects tests so that can be fixed in 5.17.1 or 5.18.0).
* Validated signatures and checksums * Verified broken tests in CI were not an issue * Check source licenses using apache rat * Built from source and ran through more tests * Ran through a custom test suite * Ran a broker from the binary package On Mon, Mar 7, 2022 at 7:34 PM Christopher Shannon < christopher.l.shan...@gmail.com> wrote: > I would hold off cancelling the vote just yet. > > I did some digging into some of the test failures and one was an issue > with the test itself (DurableFiveBrokerNetworkBridgeTest) after refactoring > that needs fixing so don't need to cancel for that : > https://github.com/apache/activemq/pull/794 > > I also looked at AMQ5212Test and that is only broken in main due to JMS > 2.0 changes so it's not broken in 5.17.0. > > I will continue to look at the other failures in the morning. We only > really need to cancel if there's a real regression. The fix for > DurableFiveBrokerNetworkBridgeTest can be merged into 5.17.1 if there are > no other issues. > > On Mon, Mar 7, 2022 at 3:43 PM Christopher Shannon < > christopher.l.shan...@gmail.com> wrote: > >> JB, >> >> Looks like we will need to cancel the vote as there are some real test >> failures on main branch in CI: >> https://builds.apache.org/job/ActiveMQ/job/ActiveMQ/job/main/114/#showFailuresLink >> >> Unfortunately the quick test profile got activated on main but not >> backported to 5.17.x by mistake so the tests didn't get run to catch the >> issues. >> >> Once we sort the failures that are real (vs flaky tests) we can re-do the >> release >> >> On Mon, Mar 7, 2022 at 12:25 PM Jean-Baptiste Onofré <j...@nanthrax.net> >> wrote: >> >>> Hi guys, >>> >>> *Finally*, after several weeks waiting, I'm pleased to submit Apache >>> ActiveMQ 5.17.0 release to your vote. >>> >>> This release is an important milestone in ActiveMQ roadmap, including 200 >>> issues, especially: >>> - support Spring 5.x >>> - support log4j 2.x (2.17.1) >>> - JDK 11+ support for both build and runtime >>> - remove of activemq-camel component (replaced by camel-activemq and >>> camel-jms components) >>> - remove leveldb >>> - tons of fixes and dependency updates >>> >>> Please take a look on the Release Notes for details: >>> >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12346476 >>> >>> Maven Staging Repository: >>> >>> https://repository.apache.org/content/repositories/orgapacheactivemq-1247/ >>> >>> Dist Staging Repository: >>> https://dist.apache.org/repos/dist/dev/activemq/activemq/5.17.0/ >>> >>> Git tag: activemq-5.17.0 >>> >>> Please vote to approve this release: >>> [ ] +1 Approve the release >>> [ ] -1 Don't approve the release (please provide specific comments) >>> >>> This vote will be open for at least 72 hours. >>> >>> Thanks ! >>> Regards >>> JB >>> >>
