Hi Robbie, Thanks for the fix. And yes, I saw the issue about apidocs symlink as well, just wanted to avoid duplicating folders. But you are right, let me fix that.
Regarding the other apidocs version, I forgot git add to add it on the website. Basically, I wanted to push the latest 5.15.15 and 5.16.4 apidocs versions. Gonna fix that as well. Thanks ! Regards JB On Tue, Mar 15, 2022 at 12:39 PM Robbie Gemmell <robbie.gemm...@gmail.com> wrote: > > I have fixed the updated website so that 5.17.0 is actually considered > a 'current' release, meaning it actually gets listed properly on the > main download page, and has the correct download links etc added. It > is generally good to look at the site update before publishing it > (using scripted 'jekyll serve'), and certainly before announcing. > > To the 'checking before publish' point, the change to delete the > src/maven/apidocs/ folder and replace it with a symlink to > src/maven/5.17.0 is causes an error from the Jekyll test server (as > below) since it ends up watching the target folder twice, directly and > then again via the symlink. > > I didnt change this back, but personally I think it makes sense to > skip the symlink and just use the apidocs folder. It would avoid such > an error, and also means the diff for adding each release would only > need to show difference in the javadoc files rather than containing > literally the entire content of the javadoc, as the commit adding > 5.17.0 does (in addition to complete content of removing the prior > apidocs content, and for some reason 5.15.8, even though a 5.15.9 > folder remains). > > > Server address: http://127.0.0.1:4000 > Server running... press ctrl-c to stop. > ** ERROR: directory is already being watched! ** > > Directory: /../activemq-website/src/maven/5.17.0/apidocs > > is already being watched through: > /.../activemq-website/src/maven/5.17.0/apidocs > > MORE INFO: https://github.com/guard/listen/blob/master/README.md > LiveReload: Browser connected > > > > On Mon, 14 Mar 2022 at 13:26, Jean-Baptiste Onofré <j...@nanthrax.net> wrote: > > > > Hi everyone, > > > > this vote passed with the following result: > > > > +1 (binding): Chris Shannon, Tim Bish, JB Onofré, Clebert Suconic > > +1 (non binding): Robbie Gemmell, WBD, Matt Pavlovich > > > > I'm promoting the artifacts on Maven Central and dist.apache.org. > > > > Then, I will prepare two PRs updates for the website: > > 1. announcement (download links, javadoc update, etc) > > 2. quick "update guide" listing major changes between ActiveMQ 5.16.x and > > 5.17.x (JDK, Spring, ...) and introducing target roadmap for ActiveMQ 5.18.x > > > > Once the website is up to date, I will send the announcement email. > > > > These tasks will probably need a day or so. > > > > Thanks all for your vote ! > > > > Regards > > JB > > > > On Thu, Mar 10, 2022 at 6:10 AM Jean-Baptiste Onofré <j...@nanthrax.net> > > wrote: > > > > > Hi guys, > > > > > > I submit ActiveMQ 5.17.0 release (take #2) to your vote. Compared to the > > > first attempt, we fixed geronimo jar version and shading of > > > activemq-client, activemq-pool, activemq-jms-pool artifacts. > > > > > > This release is an important milestone in ActiveMQ roadmap, including 200 > > > issues, especially: > > > - support Spring 5.x > > > - support log4j 2.x (2.17.1) > > > - JDK 11+ support for both build and runtime > > > - remove of activemq-camel component (replaced by camel-activemq and > > > camel-jms components) > > > - remove leveldb > > > - tons of fixes and dependency updates > > > > > > Please take a look on the Release Notes for details: > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12346476 > > > > > > Maven Staging Repository: > > > https://repository.apache.org/content/repositories/orgapacheactivemq-1248/ > > > > > > Dist Staging Repository: > > > https://dist.apache.org/repos/dist/dev/activemq/activemq/5.17.0/ > > > > > > Git tag: activemq-5.17.0 > > > > > > Please vote to approve this release: > > > [ ] +1 Approve the release > > > [ ] -1 Don't approve the release (please provide specific comments) > > > > > > This vote will be open for at least 72 hours. > > > > > > Thanks ! > > > Regards > > > JB > > >
