+1 (binding) On Mon, May 23, 2022 at 6:09 AM Robbie Gemmell <robbie.gemm...@gmail.com> wrote: > > + 1 > > I verified the checksums and signatures, checked for LICENCE+NOTICE > files, and ran a RAT check on the source archive. > > I haven't actually tried it out otherwise, only compared the diff [1]. > I noted some non-blocking niggles in the diff it might be good to fix > for future: > - Mismatched indentations from tabs vs spaces [2]. > - Incorrect link to license URL with old default branch name [3][4]. > It does redirect, so its not broken. Given that theres also a file > based property given, which is what should be looked at, maybe even > just remove the stale URL? > > (The RAT check flagged the .sln file, which as generated is ok not to > have a header, but it might be simpler just to add it if possible.) > > [1] https://github.com/apache/activemq-nms-api/compare/1.8.0...1.8.1-rc2 > [2] > https://github.com/apache/activemq-nms-api/compare/1.8.0...1.8.1-rc2#diff-c9e4f8d3720ab45fa81ee0d8249c8e19906480d689a0400d64279bad122bb131R328-R332 > [3] > https://github.com/apache/activemq-nms-api/compare/1.8.0...1.8.1-rc2#diff-9483f9de89b2620833b851d472ad8c6cd861bc4d0e4fea7984d327b0d576cee4R42 > [4] > https://github.com/apache/activemq-nms-api/compare/1.8.0...1.8.1-rc2#diff-f0dcebd9d7d9e1398afeca53c04987566f847cedb706505fcc60ed76d7f693f1R42 > > On Mon, 9 May 2022 at 21:35, Havret <hav...@apache.org> wrote: > > > > Hi all, > > > > I have put together a release of activemq-nms-api, please check it > > and vote accordingly. > > > > This release contains a single bugfix[1] by Iuliia Fatkullina! Thank you! > > > > Besides that I cherry-picked notice and license updates from the master > > branch[2]. > > > > The files can be grabbed from: > > https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-api/1.8.1-rc2/ > > > > Regards, > > Krzysztof > > > > [1]: https://issues.apache.org/jira/browse/AMQNET-745 > > [2]: > > https://github.com/apache/activemq-nms-api/commit/b837a87307aaca798b7ef6c2436d4d25b3f65c72
-- Clebert Suconic
