Ok,
I'm closing the vote until the necessary amendments are made.
Thanks,
Krzysztof
On Tue, Jun 14, 2022 at 9:14 PM W B D <w...@users.sourceforge.net> wrote:
> -1 (non-binding)
>
> Glad to see this moving forward to 2.0.x.
>
> However, I agree, we should not be defaulting to TLS 1.0 now. It should be
> at least 1.2 - or better yet defer to the OS default as recommended by
> Microsoft,
> and still allow that to be overridden.
>
> I guess this might be a simple matter of setting the default constructor of
> SslContext to initialize this("Default") instead of this("Tls")?
>
> If the OS is defaulting to 1.0, there are instructions widely available for
> how to fix that via the Windows registry.
>
> Bruce
>
> On Mon, Jun 13, 2022, 03:05 Robbie Gemmell <robbie.gemm...@gmail.com>
> wrote:
>
> > -1
> >
> > I wasnt actually going to vote given the below and as I hadn't
> > actually tried the client out, but on giving the archives a basic once
> > over for checksums etc and looking at the src licenses/notice etc
> > anyway...the same source file now used to configure the bits
> > referenced below is actually missing a licence header from when it was
> > added for this release
> > (https://github.com/apache/activemq-nms-openwire/pull/16), so it will
> > need to be updated for that regardless of anything else below.
> >
> > Robbie
> >
> > On Mon, 13 Jun 2022 at 10:20, Robbie Gemmell <robbie.gemm...@gmail.com>
> > wrote:
> > >
> > > It seems quite strange to even consider doing a new major release of
> > > this client with it still defaulting to TLS 1.0, which has been
> > > disabled on JDK releases (inc 7,8,11,17 etc) for over a year now, so
> > > this wont even be able to connect with TLS to a broker running on a
> > > remotely up to date JVM without changing config. More odd when
> > > considering one of the 3 given JIRAs is a fix related to someone
> > > actually having changed that same config needed and it not being
> > > effective during failover.
> > >
> > > https://issues.apache.org/jira/browse/AMQNET-768
> > > https://github.com/apache/activemq-nms-openwire/pull/21
> > >
> > > None of the JIRAs seem to have appropriate fix versions set. Rather
> > > than listing individual JIRAs it would be easier to set the versions
> > > and just list the release notes link, it groups everything together
> > > and can also accommodate updates.
> > >
> > > On Sat, 11 Jun 2022 at 20:55, Havret <hav...@apache.org> wrote:
> > > >
> > > > Hi all,
> > > >
> > > > I have put together a release of activemq-nms-openwire, please check
> > it and
> > > > vote accordingly.
> > > >
> > > > This release contains the following changes:
> > > > - https://issues.apache.org/jira/browse/AMQNET-637
> > > > - https://issues.apache.org/jira/browse/AMQNET-665
> > > > - https://issues.apache.org/jira/browse/AMQNET-572
> > > >
> > > > The files can be grabbed from:
> > > > *
> >
> https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-openwire/2.0.0-rc1/
> > > > <
> >
> https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-openwire/2.0.0-rc1/
> > >*
> > > >
> > > > Regards,
> > > > Krzysztof
> >
>
