I think it makes more sense for separate individual client projects to run those kinds of test, especially ones that are actually artemis-specific like this one. The broker test suite is already more than big enough. It also has its own test client in part to avoid specific other clients where possible. It would also seem odd to me to add testing with this external client in the broker test suite and not say the more general client from this project (I dont think adding tests for it into the broker suite makes sense either).
On Thu, 28 Jul 2022 at 15:20, Clebert Suconic <[email protected]> wrote: > > I think the .net test would just be an addition to the brokers test. > > I broke that test once. Having it part of the check would avoid breaking > again. > > On Thu, Jul 28, 2022 at 9:40 AM Robbie Gemmell <[email protected]> > wrote: > > > It depends on what you are aiming to achieve with the testing. If it > > is specifically to detect potential breakages affecting use of a > > component in a more timely manner as they happen, perhaps > > days/weeks/months before they ever might eventually try to be > > released, whether on the components own end or another it specifically > > requires to be used with (say since perhaps thats what it exists to > > do), then it can actually make a lot of sense, which is why plenty of > > folks do it. > > > > On Thu, 28 Jul 2022 at 14:12, Havret <[email protected]> wrote: > > > > > > 1) According to github metrics, the full test suite executes within 1 > > > minute on linux (this includes pulling artemis image from docker hub, > > > building the client from source, etc). > > > > > > 2) Currently I run the tests in my CI against the latest stable version > > of > > > Artemis, and only (after, during) each release of the broker I bump the > > > version. Running my CI pipeline against nightly doesn't make sense to me, > > > as I want my tests to be stable. Having two moving parts would make the > > > pipeline brittle. > > > > > > On Thu, Jul 28, 2022 at 10:28 AM Robbie Gemmell < > > [email protected]> > > > wrote: > > > > > > > Having the clients own CI jobs include a run against a broker nightly, > > > > if it doesnt already do so, would make more sense to me. > > > > > > > > On Thu, 28 Jul 2022 at 05:03, Clebert Suconic < > > [email protected]> > > > > wrote: > > > > > > > > > > @Havret: your .Net tests run quickly ? > > > > > > > > > > Perhaps it would be a good idea to include it as part of the GitHub > > > > actions > > > > > for Artemis! > > > > > > > > > > On Wed, Jul 27, 2022 at 1:12 PM Havret <[email protected]> wrote: > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > I've run the tests against ArtemisNetClient[1] 2.8.0. It's all > > green. > > > > > > > > > > > > To make the testing easier, I've created a docker image[2] with the > > > > release > > > > > > candidate binaries. Feel free to use it to run your tests. > > > > > > > > > > > > Cheers, > > > > > > Krzysztof > > > > > > > > > > > > [1] * > > https://github.com/Havret/dotnet-activemq-artemis-client/pull/367 > > > > > > <https://github.com/Havret/dotnet-activemq-artemis-client/pull/367 > > >* > > > > > > [2] docker pull > > > > > > havret/dotnet-activemq-artemis-client-test-broker:2.24.0-rc1 > > > > > > > > > > > > On Wed, Jul 27, 2022 at 5:54 PM Timothy Bish <[email protected]> > > > > wrote: > > > > > > > > > > > > > On 7/26/22 14:30, Clebert Suconic wrote: > > > > > > > > I would like to propose an Apache ActiveMQ Artemis 2.24.0 > > release > > > > > > > > > > > > > > > > There are two features added as part of this release: > > > > > > > > > > > > > > > > - Paging does not use soft cache any longer. As a matter of > > fact we > > > > > > > > don't have any caching now.. we just read from files straight > > to > > > > > > > > Queues > > > > > > > > - Mirror now supports encryption of password > > > > > > > > > > > > > > > > and several fixes, mainly in AMQP Mirroring > > > > > > > > > > > > > > > > Thanks for all the contributions on this release! > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > The release notes is here: > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12351822&projectId=12315920 > > > > > > > > > > > > > > > > > > > > > > > > The git commit report is here: > > > > > > > > > > > > > > > > > > > > > > > > > > > https://activemq.apache.org/components/artemis/download/commit-report-2.24.0 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Source and binary distributions can be found here: > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis/2.24.0 > > > > > > > > > > > > > > > > > > > > > > > > The Maven repository is here: > > > > > > > > > > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapacheactivemq-1259 > > > > > > > > > > > > > > > > > > > > > > > > In case you want to give it a try with the maven repo on > > examples: > > > > > > > > > > > > > > > > > > > > > > > > > > > https://activemq.apache.org/components/artemis/documentation/hacking-guide/validating-releases.html > > > > > > > > > > > > > > > > > > > > > > > > The source tag: > > > > > > > > https://github.com/apache/activemq-artemis/releases/tag/2.24.0 > > > > > > > > > > > > > > > > > > > > > > > > I will update the website after the vote has passed. > > > > > > > > > > > > > > > > > > > > > > > > [ ] +1 approve this release > > > > > > > > [ ] +0 no opinion > > > > > > > > [ ] -1 disapprove (and reason why) > > > > > > > > > > > > > > > > > > > > > > > > Here's my +1 Binding > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > +1 > > > > > > > > > > > > > > * Validated signatures and checksums > > > > > > > * Verified license and notice files present > > > > > > > * Verified source license headers using apache-rat > > > > > > > * Built from source and ran the AMQP tests > > > > > > > * Ran the binary broker instance and exercised the web console. > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > Tim Bish > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > Clebert Suconic > > > > > > > -- > Clebert Suconic
