I propose to keep this vote running and fix for next release. The broker should run fine with JDK17 (only build is impacted).
Thoughts ? If you prefer, I can cancel this vote and do a new one. No problem for me. Regards JB On Mon, Aug 29, 2022 at 4:16 PM Matt Pavlovich <mattr...@gmail.com> wrote: > > FYI— The JDK 17 building issue is due to the ianal-maven-plugin verifying > legal files. I was able to do a full build w/ JDK 17(minus unit tests) once > this was resolved. > > I have a PR running unit tests to clear this up, and will add a JDK 17 rule > to the JenkinsFile as a follow-up. > > ref: https://github.com/apache/activemq/pull/901 > <https://github.com/apache/activemq/pull/901> > > Thanks, > Matt Pavlovich > > > On Aug 29, 2022, at 8:24 AM, Christopher Shannon > > <christopher.l.shan...@gmail.com> wrote: > > > > +0, I'm ok releasing but it would be nice to fix since it's a regression. > > > > The most important thing to me is it runs on JDK 17 because the download > > page advertises as Java 11+ which as a user I'd assume is for runtime. If I > > recall we added JDK 11 build support officially in 5.17.x and not JDK 17. > > But, since it used to work on 5.17.1, it would be nice to fix it for 5.17.2 > > and redo the release (if I didn't work 5.17.1 then obviously wouldn't be a > > blocker). > > > > Going forward, I think we should officially declare JDK 17 supported for > > both building and running for version 5.18.0 but obviously fix it > > unofficially for 5.17.3 (or 5.17.2 if we respin it) as well since it used > > to work in 5.17.1 > > > > Other stuff: > > -validated checksum and signatures > > -ran through a bunch of tests (including custom tests) > > -I also ran through all the selector tests as there were changes with some > > of that and tests all passed. > > > > On Mon, Aug 29, 2022 at 7:02 AM Robbie Gemmell <robbie.gemm...@gmail.com> > > wrote: > > > >> -0 (binding) > >> > >> The build fails almost immediately on JDK 17, which is a regression > >> from 5.17.1. At this point, half way to the next JDK LTS, I personally > >> think thats a blocker for any release I do, but I've gone with -0 to > >> let the view of those doing the work here govern what happens, since > >> it does still run on 17. > >> > >> I checked things out as follows: > >> - Verified the signature and checksum files. > >> - Checked for LICENCE + NOTICE files present in the archives. > >> - Checked headers in the source archive with: mvn apache-rat:check > >> - Ran the source build and the AMQP tests on JDK 11 (per earlier comment). > >> - Ran the Qpid JMS 2.0.0 HelloWorld against a broker started from the > >> tar.gz binary on JDK 17. > >> > >> Robbie > >> > >> On Fri, 26 Aug 2022 at 06:10, Jean-Baptiste Onofré <j...@nanthrax.net> > >> wrote: > >>> > >>> Hi, > >>> > >>> I submit the ActiveMQ 5.17.2 release to your vote. > >>> > >>> This release includes 50 fixes and improvements, especially: > >>> - Spring 5.3.22 update > >>> - Jackson 2.13.13 update > >>> - Shiro 1.9.1 update > >>> - Log4j 2.18.0 update > >>> - and much more > >>> > >>> Please take a look on the Release Notes for details: > >>> > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12351602 > >>> > >>> Maven Staging Repository: > >>> > >> https://repository.apache.org/content/repositories/orgapacheactivemq-1260/ > >>> > >>> Dist Staging Repository: > >>> https://dist.apache.org/repos/dist/dev/activemq/activemq/5.17.2/ > >>> > >>> Git tag: activemq-5.17.2 > >>> > >>> Please vote to approve this release: > >>> [ ] +1 Approve the release > >>> [ ] -1 Don't approve the release (please provide specific comments) > >>> > >>> This vote will be open for at least 72 hours. > >>> > >>> Thanks ! > >>> Regards > >>> JB > >> >
