Hi Chris Thanks for fixing that. Yes, it's "just" the test, so I propose to continue the release (it's already fixed for next release cycle).
Regards JB On Fri, Jun 30, 2023 at 12:44 AM Christopher Shannon <christopher.l.shan...@gmail.com> wrote: > > FYI for anyone reviewing the release, I noticed that there is a test > failure in JournalCorruptionEofIndexRecoveryTest but it's the test itself. > There's already a fix in main here > https://github.com/apache/activemq/commit/cfbea60d6d but the backport got > missed. > > Since it's just the test that is broken I think it's fine to continue the > release as is. > > On Thu, Jun 29, 2023 at 11:09 AM Matt Pavlovich <mattr...@gmail.com> wrote: > > > +1 (non-binding) successfully ran internal test suite > > > > Thanks JB! > > > > Matt Pavlovich > > > > > On Jun 28, 2023, at 12:44 AM, Jean-Baptiste Onofré <j...@nanthrax.net> > > wrote: > > > > > > Hi, > > > > > > I submit Apache ActiveMQ 5.18.2 release to your vote. This release is > > > a maintenance release on the 5.18.x series bringing: > > > - fix potential NPE when removing consumer with selector > > > - fix composite consumers in a NoB > > > - fix memory leak on the STOMP transport when client unsubscribe > > > - a bunch of dependency updates > > > > > > You can take a look on the Release Notes for details: > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12353099 > > > > > > Maven Staging Repository: > > > > > https://repository.apache.org/content/repositories/orgapacheactivemq-1283/ > > > > > > Dist Staging Repository: > > > https://dist.apache.org/repos/dist/dev/activemq/activemq/5.18.2/ > > > > > > Git tag: activemq-5.18.2 > > > > > > Please vote to approve this release: > > > [ ] +1 Approve the release > > > [ ] -1 Don't approve the release (please provide specific comments) > > > > > > This vote will be open for at least 72 hours. > > > > > > Thanks ! > > > Regards > > > JB > > > >
