I reworked the artemis-commons module pom so that the pom output by the shade plugin is the same regardless which of the maven versions or profile combinations was in use, versus 3.8.x having 3 different possible outputs previously (tested 4 variants before/after with both 3.8.7 and 3.9.4 specifically). So we shouldnt need to consider enforcing a higher version [for this reason] now.
https://issues.apache.org/jira/browse/ARTEMIS-4822 On Tue, 18 Jun 2024 at 17:10, Robbie Gemmell <robbie.gemm...@gmail.com> wrote: > > I was looking into why the artemis-commons pom seemed to not be > reproducible in the recent releases, since I previously did some work > to get it reproducible some months ago for a completely different > issue. > > I was eventually able to piece together that use of Maven 3.9.2+ (I > was on 3.9.4 at the start, whilst reproducible-central was using > 3.9.3), coupled with whether the release profile is active or not, > explained the slight difference from what is on central for 2.34.0 and > which was published with 3.8.x > > I suggested that Clebert upgrade locally to 3.9.3+ (from looking at > the release notes) to do future releases. He suggested just enforcing > that as minimum maven version in the release profile, which I said we > could (we already enforce a lower minimum version I believe), but > should give a heads up first since it might trip up other folks still > on older versions as he originally was. > > On Tue, 18 Jun 2024 at 16:59, Clebert Suconic <clebert.suco...@gmail.com> > wrote: > > > > So... I was thinking about eventually enforcing 3.9.3+ as we talked > > about... but that might break people's CI... > > > > For now we recommend using 3.9.3 on releasing, but we may add an enforcer > > rule. > > > > On Tue, Jun 18, 2024 at 11:58 AM Clebert Suconic > > <clebert.suco...@gmail.com> wrote: > > > > > > If you are release ActiveMQ Artemis, please use Maven 3.9.3+ as it > > > improves reproducibility of the release. There are some minor issues > > > with the way artemis commons is built (shading) and having 3.9.3+ > > > during the release would improve its reproducibility. (I don't take it > > > as a major issue but it's better to upgrade... ). > > > > > > > > > I was talking "in person" with Robbie Gemmel about this and he might > > > have more context about it. > > > -- > > > Clebert Suconic > > > > > > > > -- > > Clebert Suconic > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@activemq.apache.org > > For additional commands, e-mail: dev-h...@activemq.apache.org > > For further information, visit: https://activemq.apache.org/contact > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@activemq.apache.org For additional commands, e-mail: dev-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
