Hi Arjun, Thanks for the PR! It's very much appreciated to have some help with the C++ client.
In terms of the 3.10.x branch, I honestly would probably just start over. 3.9.x has been updated more recently as you noted, so I think it would probably be best to start fresh with 3.10.x on a new branch (using this release as the basis). Once we bump the version we can go and see if there's anything that was applied to the really old 3.10.x that we want to try and cherry pick or manually move over as I really doubt we can merge with all the changes you made without doing it manually. Chris On Fri, Feb 28, 2025 at 5:51 PM Arjun Ray <ara...@gmail.com> wrote: > > > I've submitted a pull request to the repo: > > https://github.com/apache/activemq-cpp/pull/21 > > with all the changes needed for C++17 compliance. See also > > https://issues.apache.org/jira/browse/AMQCPP-756 > > Someone with committer privileges will need to pick up the ball from > here. I'm not sure what else is needed to cut/tag a 3.9.6 release, > but at a minimum I figure > > 1. Updating the pom.xml files to reflect the new version number. > 2. An appropriate Changelog entry. > > Apropos of a bump to 3.10.x, I note that the branch was cut some time > in 2018 or 2019 (!), and has commits already that are not in 3.9.x. It > looks like this was done when 3.9.4 was the latest release tag. > > I'm nowhere near enough of a git maven to mess with the merging of > divergent branches, so I'll leave that to someone who knows what to > do. But it does seem that the 3.10.x bump may not be straightforward. > Arjun > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@activemq.apache.org > For additional commands, e-mail: dev-h...@activemq.apache.org > For further information, visit: https://activemq.apache.org/contact > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@activemq.apache.org For additional commands, e-mail: dev-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
