M4rcxs commented on issue #1073: URL: https://github.com/apache/age/issues/1073#issuecomment-1670467227
> @M4rcxs Please go back and correct all of toStringList, and related PRs. Please make sure you are compiling these locally with the correct flags. > > ``` > src/backend/utils/adt/agtype.c: In function ‘age_tostringlist’: > src/backend/utils/adt/agtype.c:6278:13: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘int64’ [-Wformat=] > sprintf(buffer, "%d", elem->val.int_value); > ^ > src/backend/utils/adt/agtype.c:6213:11: warning: variable ‘float_num’ set but not used [-Wunused-but-set-variable] > float float_num; > ^ > ``` The solution I came up is change from `%d` to `%ld`, also remove the lines using `float_num` variable. I'll open refacting PR's soon, thanks for your review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@age.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
