CapnSpek commented on issue #1219: URL: https://github.com/apache/age/issues/1219#issuecomment-1785472313
Hi, I am not sure if this is the correct place to ask this question, but this is the only issue under create and merge refactor project. I wanted to ask, for example we have function `rescan_cypher_create` in cypher_create.c and `rescan_cypher_merge` in cypher_merge.c and they basically do the same thing. However, they are in different files. So is it fine if I merge the functions into a single function, create a new file, include it in the project, and reference that function in both files instead? Or should I put them in one of the files and reference from the other one? But in any case, the function will no longer be static. There are more functions from which common functionalities can be extracted and put in a common function in a new file. That is going to decrease the overall size of the files. How should I approach it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
