MironAtHome commented on issue #1840:
URL: https://github.com/apache/age/issues/1840#issuecomment-2234154794

   Branch was updated with one more function
   datum_to_agtype_map_worker
   to perform similar work, except it now does not require intermediate step of 
converting query result into jsonb type variable and, on my mind, should be 
better with regards to type safety, since handling of variable type is now 
direct
   column -> agtype
   as opposed to field -> json key/value -> agtype.
   I didn't have time beyond minimal test:
   
   ```
   LOAD 'age';
   SET search_path = ag_catalog, "$user", public;
   DO
   $RUN$
   DECLARE
       AGMap_Var agtype;
   BEGIN
        LOAD 'age';
       SET SEARCH_PATH TO ag_catalog;
       WITH t AS (
                SELECT 1 AS Col1, 'a' AS Col2
        )
       SELECT INTO AGMap_Var 
               ag_catalog.datum_to_agtype_map(t)
        FROM t AS t;
        RAISE NOTICE 'AGMap_Var : %', AGMap_Var;
   END;
   $RUN$;
   ```
   
   Please see if the two functions, datum_to_agtype_map_worker and 
jsonb_to_agtype_map can be promoted to age master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@age.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to