MironAtHome commented on issue #1985: URL: https://github.com/apache/age/issues/1985#issuecomment-2244030756
Regarding question number 2 [ label_id_is_valid ( with regards to PG_UINT16_MAX ) ] I guess, it would be very nice, if you could please help to understand, whether Age considers label id to be an Oid with range from 0 to (2*32 - 1) or something else. It seems to me, based on your answer above "something else" is correct, but than there are two separate checks for the label id makes for a great deal of confusion. While both checks Check number 1: OidIsValid Check number 2: label_id_is_valid would render label id 0 is failing check, the two carry very different suggestion with regards to what would pass the test. Check number 1 will pass with success from 1 to (2*32 - 1) Check number 2 will pass from 1 to 65535 On my mind for consistency sakes it would be nice to have one check for correctness of label id. In an ideal world what I would really like to learn from you in this question, first, before seeing any change needed or not needed, is how you see the data model, what is the true meaning of this label id, Is it a row id of a record in edge table ( in which case it should probably be generated by a sequence, unless user wants it to be something specific, when, for example, loading from file )? Is it a type id of a distinct edge? ( in which case this id should probably repeat in each applicable row for the id field ) I am honestly asking this question from the position of "unaware" user, who looks for guidance, in kind, before anything else. The two different checks and the limit value set to 65535, seem to convey enough confusion, to ask for guidance first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@age.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
