Hi Lahiru, This is great ! Please point out some code that you would like to review. We are going to have maximum 2 hrs of time for code review. Dont take too many files to review. Maximum 2 or 3 java classes with core logic.
Also send us a brief description of the functionality of those classes (prior to code review meeting). Dont explain the functionality during the code review, we will check whether functionality you described is properly implemented in the code. Also lets try to schedule a "Google Hangout" session. Thanks Amila On Tue, May 7, 2013 at 12:18 PM, Lahiru Gunathilake <[email protected]>wrote: > +1 for code review. I'd like to review gfac-core code. > > WDYT ? > > Lahiru > > > On Mon, May 6, 2013 at 12:11 PM, Suresh Marru <[email protected]> wrote: > > > + 1. For the tools, we have a choice between: > > > > http://www.reviewboard.org/ > > > > http://www.atlassian.com/software/fisheye/overview > > > > Suresh > > > > On May 6, 2013, at 11:55 AM, Amila Jayasekara <[email protected]> > > wrote: > > > > > Hi All, > > > > > > Its summer time. How about code reviews at least 2 hrs per week ? > > > But this 2 hrs should be effective and productive. > > > > > > Please give suggestions to have an effective code review. > > > Afterwards lets come up with fixed rules for code reviews. > > > > > > Thanks > > > Amila > > > > > > > -- > System Analyst Programmer > PTI Lab > Indiana University >
