+1 On Fri, Jun 15, 2018 at 8:09 AM, Christie, Marcus Aaron <[email protected]> wrote:
> Hi Suresh, > > Yes the timing was interesting. 3.0.0 was just released yesterday! I too > would consider the 2.4.x branch a good stable one to use, let’s give 3.0.0 > some more time. > > Thanks, > > Marcus > > > On Jun 14, 2018, at 3:14 PM, Suresh Marru <[email protected]> wrote: > > Hi Marcus, > > This seems like a good and needed upgraded. Looking at OpenJPA commits, > seems like they 2.4.x branch is stable enough to move. Looks like we need > to have a roadmap to consider 3.0.0 migration in future. Seems like minor > API changes will be needed at that point. > > Thanks, > Suresh > > On Jun 14, 2018, at 9:35 AM, Christie, Marcus Aaron <[email protected]> > wrote: > > Any objections to upgrading to OpenJPA 2.4.3? I think now is probably a > good time, since we in any case need to do a lot of testing of the registry > refactoring code changes. > > A couple motivating reasons: > > * In Maven we have a compile time dependency on OpenJPA 2.3.0 [1], but we > are actually using 2.2.0 [2] to do the build time entity class enhancement. > The reason for this is that doing build time entity class enhancement with > 2.3 doesn’t work with Java 8, but OpenJPA 2.4 does support Java 8. Also > turns out that at runtime for some reason we end up with OpenJPA 2.2.0, > which is a more than 6 years old version of OpenJPA. Upgrading to 2.4.3 > would allow us to depend on a single version across all the Airavata > modules. > * I’ve run into what looks like a bug [3] in OpenJPA 2.2.0, so I’m > motivated to upgrade to OpenJPA 2.4.3 to see if that fixes it. > > FWIW, I locally updated the registry-refactoring module to 2.4.3 and `mvn > clean test` runs successfully, so this should be a drop in replacement. > > Thanks, > > Marcus > > [1] https://github.com/apache/airavata/blob/group-based- > auth/modules/registry-refactoring/pom.xml#L44 > [2] https://github.com/apache/airavata/blob/group-based- > auth/modules/registry-refactoring/pom.xml#L135 > [3] https://issues.apache.org/jira/browse/AIRAVATA-2827 > > > >
