Thanks for your feedback, Marcus!

Regarding the data-product, I am not fetching all experiment inputs from
the array *experiment.experimentInputs* because when I try to use the
<data-product-viewer> tag on the *input.value *field, Vue throws a warning
"Invalid prop: type check failed for prop "dataProduct". Expected
DataProduct, got Object" for inputs of type 'URI'. I guessed this is
because *experimentInputs *array contains normal objects and not
DataProducts, so I am fetching DataProducts from the existing
*inputDataProducts
*array itself (it doesn't have a name field (only productName), hence I
couldn't keep the *inputName: value *format for the bullets).

Questions:

   1. Is my above approach fine? It works properly and gets all the
   required information apart from the *inputName *for URI inputs
   2. Am I right to assume that the existing *inputDataProducts *array is
   being formed by the API using getDataProduct(), like you mentioned? If so,
   should the API be modified to add an 'inputName' field too?
   3. If not, how would I go about fetching the DataProduct by passing the
   data product URI from Vue? I checked existing Vue Services and couldn't
   find one which is related. I might be looking at the wrong places, however.

Once again, thank you so much for your patience!

Thanks & Regards,
Aravind Parappil
Master of Science in Computer Science, 2020
School of Informatics, Computing, and Engineering
Indiana University Bloomington


On Mon, Apr 8, 2019 at 12:25 PM Christie, Marcus Aaron <machr...@iu.edu>
wrote:

> Hi Aravind,
>
> On Apr 7, 2019, at 2:31 PM, Aravind Parappil <aravindparap...@gmail.com>
> wrote:
>
> Hi team,
>
> I have worked on the bug
> <https://issues.apache.org/jira/browse/AIRAVATA-2975>where String inputs
> to experiments were not being shown on Experiment Summary page of the
> Django portal.
>
> However, I have a couple of doubts before I decide to proceed with a PR on
> the same.
>
>    1. I was testing the working of string input using already existing *Echo
>    *experiments. However, it takes only 1 input. Is there an application
>    that takes more than 1 string input so that I can test whether my
>    implementation works for multiple strings?
>
> You can create an Application with more than one input of type string. You
> can look at the Echo application, go to /admin/applications/ to see a list
> of applications and click on one to edit the application. Go to the
> Interface tab and then you can see how the inputs are defined and add
> additional ones.
>
>
>    1. Am I allowed to create new experiments? If yes, on which resource
>    (Big Red?)
>
>
> For now, just save the experiments but don't launch them.
>
> Here is my approach:
>
>    - Created a new computed property (*stringInputs*) that filters out
>    *experimentInputs *of type STRING from *experiment *object
>       - Had to do this (and not take everything from *experimentInputs) 
> *because
>       *experimentInputs* do not contain objects of type data-product
>       - @Christie, Marcus Aaron <machr...@iu.edu> - is it possible to
>       convert an obj into a data-product?
>
> I'm not sure what you are asking here. The experiment input 'value' is a
> data product URI when the type of the experiment input is 'URI'. The data
> product has to be separately fetched from the API using getDataProduct(),
> passing the data product URI.
>
>
>    - Populate a bulleted list of *inputName: value, *if any exist
>    - Kept the earlier logic for displaying data-products (wrapped it in a
>    <template> so that it doesn't render on the DOM if no input files exist)
>
> Here's how it looks now:
> <image.png>
>
> Above is from experiment *Abinit on Aug 1, 2018 3:49 PM*. First input is
> a string, others are files
>
>
> This looks really good. One suggestion, use the "inputName: value" format
> for all the inputs and display them in the same order as they are in the
> "experiment.experimentInputs" array.
>
>
> Thanks & Regards,
> Aravind Parappil
> Master of Science in Computer Science, 2020
> School of Informatics, Computing, and Engineering
> Indiana University Bloomington
>
>
>

Reply via email to