machristie commented on issue #3: Initial vault based credential store + Rest 
API framework with SSH and AWS credential support
URL: https://github.com/apache/airavata-custos/pull/3#issuecomment-510953435
 
 
   @DImuthuUpe +1, looks good to me. I like the use of Spring Boot.
   
   Some questions
   - from the code looks like Vault clients have a token they use for 
authorization. Eventually we'll provide these in a config file? Also is it 
possible to do fine grained authorization with these tokens, for example, 
create a token that can only read keys for a specific tenant, i.e, can only 
read `/secret/ssh/seagrid/*` for example?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to