isururanawaka commented on a change in pull request #11: User Profile SDK URL: https://github.com/apache/airavata-custos/pull/11#discussion_r340074624
########## File path: clients/python/airavata_custos/admin/iam_admin_client.py ########## @@ -16,24 +16,22 @@ # import logging -import configparser from airavata_custos import utils -from airavata_custos.settings import ProfileSettings +from airavata_custos.configuration import Configuration logger = logging.getLogger(__name__) class IAMAdminClient(object): - def __init__(self, configuration_file_location): + def __init__(self, configuration: Configuration): Review comment: Encapsulation of configuration info into Configuration is good ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
