machristie commented on pull request #260:
URL: https://github.com/apache/airavata/pull/260#issuecomment-683982167
@vivekshresta,
Regarding validating internally, I would add the check to launchExperiment
instead of createExperiment.
> We will check the size limit only after the experiment creation is done.
That's true, but the current approach only checks before the experiment runs
and so doesn't account for experiment output files.
> When we know the size limit is exceeded, helix needs to communicate back
to APIServer for deleting the created
> experiment entries and if needed, deleting the experiment directory.
> Considering these and after discussing with Dimuthu, I thought this
might be the better approach when we use 'StorageResourceAdaptor', but this
does seem to complicate things.
Well, my two cents, but I don't think the experiment needs to be deleted. We
just need to set a flag in the database that the user is over quote on that
storage resource and then prevent further file uploads/experiments on that
storage resource.
> Also can you please elaborate a little on transient network failure in
helix.
Sure, Helix's task framework has builtin fault tolerance support, for
example retrying in the case of failure:
https://helix.apache.org/0.8.0-docs/tutorial_task_framework.html. By transient
network failure I mean some sort of transient network failure between Airavata
and the SSH host that prevents the SSH connection from establishing or
completing successfully.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
