machristie commented on a change in pull request #52:
URL:
https://github.com/apache/airavata-django-portal/pull/52#discussion_r570561719
##########
File path: django_airavata/apps/api/serializers.py
##########
@@ -513,6 +515,13 @@ def get_isInputFileUpload(self, data_product):
request = self.context['request']
return user_storage.is_input_file(request, data_product)
+ def get_path(self, data_product):
+ """Getter for path field."""
+ if len(data_product.replicaLocations) > 0:
+ return re.sub(r'.*/tmp/[^/]*/', "",
user_storage._get_replica_filepath(data_product))
Review comment:
Neither of those work for me when I try the code locally. Conceptually,
from the API you should only need to provide the data product uri to edit a
file, the path shouldn't be needed. The backend can take care of figuring out
where the file is actually located.
Maybe we should meet to figure out a way forward.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
