machristie commented on a change in pull request #56:
URL: 
https://github.com/apache/airavata-django-portal/pull/56#discussion_r599981705



##########
File path: django_airavata/static/common/js/layouts/ListLayout.vue
##########
@@ -7,7 +7,16 @@
         </slot>
       </div>
       <div class="col-auto">
-        <slot name="additional-buttons"> </slot>
+        <slot name="additional-buttons"> 

Review comment:
       Instead of adding the buttons here, you can just use this slot in 
CredentialStoreDashboard.vue.  See ComputeResourceReservationList.vue for an 
example of adding an additional-buttons slot.

##########
File path: 
django_airavata/apps/admin/static/django_airavata_admin/src/components/dashboards/CredentialStoreDashboard.vue
##########
@@ -5,6 +5,9 @@
       :items="sshKeys"
       title="SSH Credentials"
       new-item-button-text="New SSH Credential"
+      @admin-action="showNewSharedSSHCredentialModel"
+      :adminButton="userIsAdmin"
+      admin-button-text = "New Shared SSH Credential"

Review comment:
       Let's label the button "New Gateway SSH Credential"




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to