DImuthuUpe commented on a change in pull request #278:
URL: https://github.com/apache/airavata/pull/278#discussion_r789664111



##########
File path: 
dev-tools/ansible/roles/job_monitor/templates/email-monitor/email-config.yaml.j2
##########
@@ -93,3 +93,7 @@ config:
      resourceEmailAddresses:
        - iu.xsede.edu # test resource mail address
        - tcs.tulsahpc.org #Tandy
+
+   - jobManagerType: HTCondor

Review comment:
       No. For email monitor, the parser is fetched from this line 
https://github.com/apache/airavata/blob/htcondor-new/modules/job-monitor/email-monitor/src/main/java/org/apache/airavata/monitor/email/EmailBasedMonitor.java#L130.
 So the value in email-config.yml should be "HTCondor" as it is pointing to the 
parser 
https://github.com/apache/airavata/blob/htcondor-new/modules/job-monitor/email-monitor/src/main/java/org/apache/airavata/monitor/email/parser/HTCondorEmailParser.java
   
   However, the HTCondo custom override in GrrovyMapBuilder should be removed 
as it kills the generic behavior of the code. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@airavata.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to