yasithdev opened a new pull request, #189:
URL: https://github.com/apache/airavata-portals/pull/189

   ## Summary
   
   Migrate the remaining straggler Thrift **reads** (those not entangled with 
the storage / data-product write path, which is D4.2/D4.3) to the gRPC facades, 
reusing the adapters established in the D2 read families.
   
   - **`FullExperimentViewSet.get_instance`**: `getExperiment` / 
`getApplicationInterface` / `getApplicationModule` / `getComputeResource` / 
`getProject` / `getJobDetails` / `userHasAccess` → research/compute facades + 
adapters and the `user_has_access` sharing helper. (Its data-product reads were 
already gRPC from D4.1 / #186.)
   - **`ApplicationModuleViewSet.application_interface` / 
`application_deployments`** actions: `getAllApplicationInterfaces` / 
`getAllApplicationDeployments` → `research.get_all_application_interfaces` / 
`get_accessible_application_deployments` + adapters, keeping the same module-id 
filtering.
   - **`ExperimentViewSet.clone`**: re-fetch the cloned experiment via 
`research.get_experiment` (the `experiment_util.clone` orchestration stays 
Thrift — separate concern).
   - **`output_views.generate_data`**: `getExperiment` → 
`research.get_experiment`.
   - **`workspace/views.edit_experiment`**: `getExperiment` / 
`getApplicationInterface` → research facades (derives `app_module_id` for 
template rendering).
   
   After this, the only remaining `request.airavata_client` call sites are the 
two intentionally-deferred admin views — `GlobusJobSubmissionView` (broken 
`getClo`, no facade getter) and `UnicoreDataMovementView` (no facade getter) — 
both already flagged with a TODO.
   
   ## Validation
   
   REST/JSON contract unchanged (reuses the proven D2 adapters). `manage.py 
check` clean; all view modules import; the facade calls round-trip structurally 
against the live backend (empty lists / proper errors for absent data, matching 
the dev-data limits).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to