yasithdev opened a new pull request, #192:
URL: https://github.com/apache/airavata-portals/pull/192

   ## Summary
   
   With the functional Thrift→gRPC migration complete, nothing reads 
`request.airavata_client` except two admin-only per-protocol detail views that 
never worked on the gRPC stack:
   
   - **`GlobusJobSubmissionView`** called `request.airavata_client.getClo` — a 
typo that always `AttributeError`'d (the view was already broken upstream).
   - **`UnicoreDataMovementView`** used `getUnicoreDataMovement`, for which the 
gRPC SDK has no facade getter.
   
   This deletes both views (+ their URL routes and the now-unused 
`GlobusJobSubmission` / `UnicoreDataMovement` Thrift-model imports), removing 
the last `request.airavata_client` consumers — then removes the legacy Thrift 
client itself:
   
   - `AiravataClientMiddleware` (and its `settings.MIDDLEWARE` registration)
   - the entire `django_airavata/utils.py` Thrift-client module (the airavata 
API Thrift pool, transports, connection helpers) — nothing imports it anymore
   - the `thrift_connector` dependency and the now-unused 
`THRIFT_CLIENT_POOL_KEEPALIVE` setting
   
   Net −342 lines.
   
   ### What stays (interim)
   
   The `thrift_utils`-generated DRF serializers + 
`grpc_adapters`/`grpc_requests` still read Thrift model **types** 
(`airavata.model.*.ttypes`), so `airavata-python-sdk==2.2.7` and the `thrift` 
lib remain **for the model types only** — no Thrift client/transport. Those 
types are dropped in the later serializer/terminology pass.
   
   ## Validation
   
   `manage.py check` clean. The request pipeline serves gRPC requests without 
`AiravataClientMiddleware` (verified live — a gRPC per-protocol view reaches 
the backend). No remaining `request.airavata_client` references; the two 
deleted views are gone with the sibling per-protocol views (SSH/Cloud/Unicore 
job submission, Local/SCP/GridFTP data movement) intact.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to