As a user/reporter on other opensource projects I would personally see auto-close after 30 days to be far too aggressive to the point of being unfriendly to contributions.
Unless we get markedly better at merging PRs I wouldn't want to see us mark as stale so quickly. -ash > On 22 Apr 2019, at 22:07, Jarek Potiuk <jarek.pot...@polidea.com> wrote: > > Here is a better search showing all the 103 issues - all of them "updated" > 17 days ago > https://github.com/apache/airflow/pulls?page=1&q=is%3Apr+is%3Aopen+updated%3A%3C2019-04-06+sort%3Aupdated-desc > > On Mon, Apr 22, 2019 at 11:06 PM Jarek Potiuk <jarek.pot...@polidea.com> > wrote: > >> I think current stalebot configuration will not help us for quite a while >> for mysterious reason. >> >> I looked at the current PRs and somehow mysteriously vast majority of >> issues (even issues last-commented in 2017) have been updated 17 days ago. >> <https://drive.google.com/file/d/19GF1fdpYa2Tf25N3XgAEKrdXBwr9mNH9/view?usp=sharing> >> >> It looks like they were all updated on *6th of April, at 00:13 CEST*. >> >> There are 103 such issues: >> https://github.com/apache/airflow/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aopen+updated%3A%3C2019-04-06+. >> It would be nice to find out why this happened. >> >> From stalebot documentation: "Any change to an issues and pull request is >> considered an update, including comments, changing labels, applying or >> removing milestones, or pushing commits.". I think none of that happened to >> most of the 103 issues (i checked a few and could not find any trace of any >> such changes). But maybe someone can recall something that happened 6th of >> April around midnight (Saturday). >> >> Current configuration of stalebot (.github/stalebot.yaml) says: 45 days >> (mark as stakle) and further 7 days (closing). So those issues will be >> marked as stale by the stalebot around May 20th (providing that such update >> won't happen again). >> >> Maybe then we can set it to 20 days + 7 for now to stale most issues up >> in 3 days and delete them 10 days from now? If the config will be too >> aggressive we can change it back after the 103 issues are cleaned-up. >> >> >> J. >> >> On Thu, Apr 18, 2019 at 7:54 AM airflowuser >> <airflowu...@protonmail.com.invalid> wrote: >> >>> It's already on (or at least was on in December 2018). >>> >>> >>> In any case here is a list of old PRs that are waiting for committers. >>> >>> [AIRFLOW-1956] Add parameter whether the navbar clock time is UTC >>> https://github.com/apache/airflow/pull/2906 >>> Status: ash commented but there are no further instructions. >>> >>> [AIRFLOW-620] Feature to tail custom number of logs instead of rendering >>> whole log >>> https://github.com/apache/airflow/pull/3992 >>> Status: Pushed changed in Jan 2019 that were not reviewed >>> >>> AIRFLOW-3149 Support dataproc cluster deletion on ERROR >>> https://github.com/apache/airflow/pull/4064 >>> Status: pushed changes today. CI passed. >>> >>> [AIRFLOW-1424] make the next execution date of DAGs visible >>> https://github.com/apache/airflow/pull/2460 >>> Status: not sure. Waiting for ash ? >>> >>> [AIRFLOW-1488] Add the TriggeredDagRunSensor operator >>> https://github.com/apache/airflow/pull/4291 >>> Status: Waiting for code review >>> >>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ >>> On Thursday, April 18, 2019 12:01 AM, Daniel Imberman < >>> dimberman.opensou...@gmail.com> wrote: >>> >>>> As part of our effort to reduce the PR backlog I wanted to proposed that >>>> we set the github stale action https://github.com/apps/stale. This will >>>> allow us to temporarily close PRs/tickets that are not actively being >>>> worked on. >>>> >>>> (note that this will not remove PRs, it will simply mark PRs as stale to >>>> make it easier for committers) >>> >>> >>> >> >> -- >> >> Jarek Potiuk >> Polidea <https://www.polidea.com/> | Principal Software Engineer >> >> M: +48 660 796 129 <+48660796129> >> E: jarek.pot...@polidea.com >> > > > -- > > Jarek Potiuk > Polidea <https://www.polidea.com/> | Principal Software Engineer > > M: +48 660 796 129 <+48660796129> > E: jarek.pot...@polidea.com
