I'm not sure this even warrants an AIP. What do people think? Once the tests are passing (and making them pass is a good thing as it means they are less reliant on side-effects or ordering from previous tests) this isn't that big a change, right?
(+1 though. Love py-test) -a > On 30 Oct 2019, at 14:49, Jarek Potiuk <[email protected]> wrote: > > I think it's the right time to vote - I think the benefits are obvious and > seeing the number of problems you already fixed (I followed the draft PR) > it is quite doable to finish that in a short time. > > Just in case (+1 binding) from my side. > > J. > > On Wed, Oct 30, 2019 at 3:36 PM Tomasz Urbaszek <[email protected]> > wrote: > >> Hi all, >> >> I have opened a draft PR with tests run by pytest: >> https://github.com/apache/airflow/pull/6472 >> >> Still, 13 tests are failing. It has increased since friday where I have >> only two failing (the new ones are cassandara and hive related). >> I share this code to get some inspiration and suggestions how can we >> approach this subject. Any help is appreciated! >> >> Seeing a number of likes in this thread, should we proceed with official >> vote for AIP-27 >> < >> https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-27+Migrate+to+pytest >>> >> ? >> >> Best wishes, >> Tomek >> >> On Wed, Oct 16, 2019 at 6:26 PM Dan Davydov <[email protected]> >> wrote: >> >>> +1 >>> >>> On Wed, Oct 16, 2019 at 12:01 PM Christian Lellmann >>> <[email protected]> wrote: >>> >>>> +1 from my side too. >>>> >>>> Regards, >>>> >>>> Chris >>>> >>>> Driesprong, Fokko <[email protected]> schrieb am Mi., 16. Okt. >> 2019, >>>> 17:01: >>>> >>>>> +1 >>>>> >>>>> Op ma 14 okt. 2019 om 16:50 schreef Felix Uellendall >>>>> <[email protected] >>>>>> : >>>>> >>>>>> +1, successfully using pytest for airflow plugins for almost 2 >> years >>>> now. >>>>>> >>>>>> Felix >>>>>> >>>>>> Sent from ProtonMail Mobile >>>>>> >>>>>> On Mon, Oct 14, 2019 at 16:39, Daniel Imberman < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> Huge +1 from me on this one! >>>>>>> >>>>>>> On Mon, Oct 14, 2019 at 10:46 AM Bas Harenslak < >>>>>>> [email protected]> wrote: >>>>>>> >>>>>>>> Big +1 for pytest >>>>>>>> >>>>>>>> Bas >>>>>>>> >>>>>>>>> On 14 Oct 2019, at 15:29, Jarek Potiuk < >>> [email protected]> >>>>>> wrote: >>>>>>>>> >>>>>>>>> Fantastic! Pytest is sooo much better than nosetests! >>>>>>>>> >>>>>>>>> On Mon, Oct 14, 2019 at 1:44 PM Ash Berlin-Taylor < >>> [email protected] >>>>> >>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> Awesome, thanks! >>>>>>>>>> >>>>>>>>>> I tried this at the start of the year but we were a few 100 >>>> failing >>>>>>>> tests >>>>>>>>>> away. >>>>>>>>>> >>>>>>>>>> -ash >>>>>>>>>> >>>>>>>>>>> On 14 Oct 2019, at 11:44, Tomasz Urbaszek < >>>>>> [email protected] >>>>>>>>> >>>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>> Hi all, >>>>>>>>>>> >>>>>>>>>>> I've just created AIP-27 Migrate to pytest >>>>>>>>>>> < >>>>>>>>>> >>>>>>>> >>>>>> >>>>> >>>> >>> >> https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-27+Migrate+to+pytest >>>>>>>>>>> . >>>>>>>>>>> I think this proposal will improve our test suite especially >>>> that >>>>> it >>>>>>>>>> seems >>>>>>>>>>> that we only need to fix 16 tests to obtain green CI build. >>>>>>>>>>> >>>>>>>>>>> Your considerations and feedback are highly welcomed! >>>>>>>>>>> >>>>>>>>>>> Bests, >>>>>>>>>>> Tomek >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> >>>>>>>>> Jarek Potiuk >>>>>>>>> Polidea <https://www.polidea.com/> | Principal Software >>> Engineer >>>>>>>>> >>>>>>>>> M: +48 660 796 129 <+48660796129> >>>>>>>>> [image: Polidea] <https://www.polidea.com/> >>>>>>>> >>>>>>>> >>>>> >>>> >>> >> >> >> -- >> >> Tomasz Urbaszek >> Polidea <https://www.polidea.com/> | Junior Software Engineer >> >> M: +48 505 628 493 <+48505628493> >> E: [email protected] <[email protected]> >> >> Unique Tech >> Check out our projects! <https://www.polidea.com/our-work> >> > > > -- > > Jarek Potiuk > Polidea <https://www.polidea.com/> | Principal Software Engineer > > M: +48 660 796 129 <+48660796129> > [image: Polidea] <https://www.polidea.com/>
