jason810496 commented on code in PR #55306:
URL: https://github.com/apache/airflow/pull/55306#discussion_r2327647815
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/import_error.py:
##########
@@ -179,19 +179,21 @@ def get_import_errors(
limit=limit,
session=session,
)
- import_errors_result: Iterable[tuple[ParseImportError, Iterable[str]]] =
groupby(
+ import_errors_result: Iterable[tuple[ParseImportError, Iterable]] =
groupby(
Review Comment:
May I ask why do we need to change this?
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/import_error.py:
##########
@@ -179,19 +179,21 @@ def get_import_errors(
limit=limit,
session=session,
)
- import_errors_result: Iterable[tuple[ParseImportError, Iterable[str]]] =
groupby(
+ import_errors_result: Iterable[tuple[ParseImportError, Iterable]] =
groupby(
session.execute(import_errors_select), itemgetter(0)
)
import_errors = []
for import_error, file_dag_ids in import_errors_result:
+ dag_ids = [dag_id for _, dag_id in file_dag_ids]
Review Comment:
It seems like the `file_dag_ids` is still `Iterable[str]` ?
```suggestion
dag_ids = [dag_id for dag_id in file_dag_ids]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
