topherinternational commented on code in PR #53821:
URL: https://github.com/apache/airflow/pull/53821#discussion_r2328289928
##########
providers/elasticsearch/tests/unit/elasticsearch/log/test_es_task_handler.py:
##########
@@ -131,7 +136,7 @@ def teardown_method(self):
def test_es_response(self):
sample_response = self.es.sample_log_response()
es_response = ElasticSearchResponse(self.es_task_handler,
sample_response)
- logs_by_host = self.es_task_handler._group_logs_by_host(es_response)
+ logs_by_host = self.es_task_handler.io._group_logs_by_host(es_response)
def concat_logs(lines):
log_range = -1 if lines[-1].message ==
self.es_task_handler.end_of_log_mark else None
Review Comment:
Looks great! Thanks for fixing.
##########
providers/elasticsearch/tests/unit/elasticsearch/log/elasticmock/fake_elasticsearch.py:
##########
@@ -104,19 +104,22 @@ def sample_log_response(self, headers=None, params=None):
"file": {
"path":
"/opt/airflow/Documents/GitHub/airflow/logs/"
"dag_id=example_bash_operator'"
-
"/run_id=owen_run_run/task_id=run_after_loop/attempt=1.log"
+
"/run_id=run_run/task_id=run_after_loop/attempt=1.log"
},
"offset": 0,
},
"log.offset": 1688888863907337472,
- "log_id":
"example_bash_operator-run_after_loop-owen_run_run--1-1",
+ "log_id":
"example_bash_operator-run_after_loop-run_run--1-1",
"message": "Dependencies all met for "
"dep_context=non-requeueable deps "
"ti=<TaskInstance: "
- "example_bash_operator.run_after_loop "
- "owen_run_run [queued]>",
+ "example_bash_operator.run_after_loop ",
"task_id": "run_after_loop",
"try_number": "1",
+ "event": "Dependencies all met for "
Review Comment:
Looks great! Thanks for fixing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
