MaksYermak commented on issue #49881:
URL: https://github.com/apache/airflow/issues/49881#issuecomment-3265781671

   @amoghrajesh this issue wasn't fixed by adding the `get_uri()` method to the 
`Connection` object. This issue is about different interfaces for `Connection` 
classes from `models` and `task-sdk`. Previously for `Connection` from `models` 
we can create an object using only the `uri` parameter.  For `Connection` from 
`task-sdk` we do not have this option anymore now we need to specify each 
parameter itself.
   
   In the google provider for `cloud_sql` we generate a different URIs 
depending on different types of DB and then create a `Connection` using this 
generated URI. The absence of this parameter in the interface for `Connection` 
from `task-sdk` blocks us for smooth migration for `cloud_sql` hook.
   
   If we are not planning to add this `uri` parameter for creating a 
`Connection` then for `cloud_sql` hook we need to do a big refactoring by using 
this new approach for creating a `Connection`. As I see this potential 
refactoring may cause some problems.
   
   @kaxil @potiuk do we have some dates or Airflow versions when we are 
planning to completely remove the `Connection` from `models`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to