ashb commented on code in PR #55370:
URL: https://github.com/apache/airflow/pull/55370#discussion_r2330289269
##########
providers/postgres/pyproject.toml:
##########
@@ -83,6 +83,9 @@ dependencies = [
"psycopg" = [
"psycopg[binary]>=3.2.9",
]
+"psycopg-c" = [
+ "psycopg[c]>=3.2.9",
+]
Review Comment:
To summarise my view from the discussion on Slack;
1. The binary package works fine in production, based on past experience I
don't trust the psygopg dev's views on binary packages. I have been using the
binary package of v3 in production at a scale larger than any individual
airflow deployment fine for two years.
So I don't see the need to change the prod image right now. Why change
was isn't broken? A "but it performs better" claim needs number to back it.
1. I don't see that an extra is worth it. Just document "you can install the
c extension if you want" since we have to document the presence of extras
anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
